Monday, 2 December 2013

Suspend fixes for BFS 443

Investigating the hibernate/suspend/resume problems I discovered a fix that is necessary in BFS443. These changes have nothing to do with the experimental patches I've posted so if you have applied any of those you will have to roll back to BFS443 or 3.12-ck1 to apply this patch since it affects the same code. Hopefully these changes actually address the suspend issues people are having and the workarounds in the experimental patches won't be required - note that you will not be able to apply any of the experimental patches on top of this:

EDIT: Added an updated bindzero patch; apply in this order:
01 bfs443-suspend-fixes.patch
02 bfs443-bindzero.patch

Those with hibernate/resume issues please report back so I know what more needs to be done on top of this code.

14 comments:

  1. No automatic power off at the end of hibernation. Lots of worker threads after resuming.

    ReplyDelete
    Replies
    1. Okay I didn't think it would be a comprehensive fix but those changes were necessary anyway. Will rework the other patch I posted to apply on top, thanks.

      Delete
  2. Thanks ck. But your link seems broken, just the patch file name pasted. I think it locates at http://ck.kolivas.org/patches/bfs/3.0/3.12/bfs443-suspend-fixes.patch

    ReplyDelete
  3. I've added an updated bindzero patch in the links above which applies on top and avoids the warning of the previous patch as well.

    ReplyDelete
    Replies
    1. Now automatic power off at the end of hibernation works. No warnings inside dmesg on resume. However, still lots of additional kworker threads after resuming ([kworker/u4:i] with 9<=i<= 68).

      Delete
    2. Great thanks for testing. I think you'll find the workers disappearing later on.

      Delete
    3. Yes, they've disappeared now. Great thanks for the patches.

      Delete
    4. I will likely package these two changes into an official new BFS after a bit more testing.

      Delete
  4. Hibernation seems to be working now.
    Thanks for your effort.

    ReplyDelete
    Replies
    1. You're welcome, thanks for reporting and testing.

      Delete
  5. Works for me as well. Many thanks!

    ReplyDelete
  6. Thank you for your work, Con! Fine on here, too. With addon BFQ.
    (The missing serial mouse _is_ a kernel issue to be solved soon. Preliminary -working- patches let me hope for a good ending. ) :-))) (Sorry for possible headaches!)

    Best regards, Manuel Krause

    ReplyDelete
  7. OT: @Ralph Ullrich: I've finally managed to analyze the diff of our .config files over the last weekend. Three days, three steps. Now I'm at ~38min compile time. Down from original ~90min.
    Thank you very much for providing your .config to let me optimize my kernel!
    Mine is now like: http://pastebin.com/jzPt86wX

    Best regards, Manuel Krause

    ReplyDelete